Eldan Shachar has posted comments on this change.

Change subject: core: Add migration options to OVF
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/32899/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java:

Line 886:      *
Line 887:      * @param vm                  - the VM to check
Line 888:      * @param canDoActionMessages - Action messages - used for error 
reporting. null value indicates that no error messages are required.
Line 889:      * @return
Line 890:      */
> The name can be changed since you returning true if you don't have a dedica
Done
Line 891:     public static boolean isDedicatedVdsExistOnSameCluster(VmBase vm, 
ArrayList<String> canDoActionMessages) {
Line 892:         boolean result = true;
Line 893:         if (vm.getDedicatedVmForVds() != null) {
Line 894:             // get dedicated host id


-- 
To view, visit http://gerrit.ovirt.org/32899
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f0025e5ac59dac0a1569729c2fef8186e0885db
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eldan Shachar <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Eldan Shachar <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to