Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: sharpen the test for engine enabled ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/36217/3/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/misc.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/misc.py: Line 54: stage=plugin.Stages.STAGE_SETUP, Line 55: ) Line 56: def _setup(self): Line 57: config = configfile.ConfigFile([ Line 58: oenginecons.FileLocations.OVIRT_ENGINE_SERVICE_CONFIG_DEFAULTS, Drop this? Fails if local fqdn is the same as the default there, 'localhost.localdomain' Line 59: oenginecons.FileLocations.OVIRT_ENGINE_SERVICE_CONFIG Line 60: ]) Line 61: if config.get('ENGINE_FQDN'): Line 62: self._engine_fqdn = config.get('ENGINE_FQDN') -- To view, visit http://gerrit.ovirt.org/36217 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie58fcaff0925f3b5ac16fc5159a3eda4498f0b6e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
