Alon Bar-Lev has posted comments on this change. Change subject: services, setup: Serial console proxy [WIP] ......................................................................
Patch Set 2: (2 comments) ok, tell me when the client use certificate. http://gerrit.ovirt.org/#/c/35906/2/packaging/services/ovirt-console-proxy/vmproxy File packaging/services/ovirt-console-proxy/vmproxy: Line 20: Line 21: return user_guid, vm_name Line 22: Line 23: def run_virsh_console(vm, host): Line 24: os.execlp('virsh', 'virsh', '-c', 'qemu+tls://' + host + '/system', 'console', vm) > The client certificate signed by the engine CA. where do you specify the location? Line 25: Line 26: def main(): Line 27: # FIXME: Logger Line 28: http://gerrit.ovirt.org/#/c/35906/2/packaging/setup/ovirt_engine_setup/console_proxy/constants.py File packaging/setup/ovirt_engine_setup/console_proxy/constants.py: Line 73: OVIRT_ENGINE_PKI_CONSOLE_CERT = \ Line 74: os.path.join(ocpconfig.VMPROXY_DIR, '.pki/libvirt/clientcert.pem') Line 75: Line 76: OVIRT_ENGINE_PKI_CONSOLE_KEY = \ Line 77: os.path.join(ocpconfig.VMPROXY_DIR, '.pki/libvirt/clientkey.pem') > Libvirt expects them to be there, but you can change the folder where these explicit location is always better than implicit. Line 78: Line 79: OVIRT_ENGINE_CONSOLE_PROXY_HOST_KEY = \ Line 80: ocpconfig.ENGINE_CONSOLE_PROXY_SSH_HOST_KEY_PATH Line 81: -- To view, visit http://gerrit.ovirt.org/35906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I034ef8e6d10da5dc93eda61e0c5c518ca13a5a28 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
