Alon Bar-Lev has posted comments on this change. Change subject: core, engine: Services for providing info to the Console Proxy ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/35887/3/backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/GetAvailableConsoles.java File backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/GetAvailableConsoles.java: Line 30: Line 31: private boolean runQuery(HttpServletRequest request, OutputStream out) { Line 32: BackendInternal backend = null; Line 33: Line 34: String userGuidAsString = request.getParameter("user_guid"); it should be user id all over, you should not assume that it is guid, it will likely to be changed soon anyway. Line 35: Line 36: Guid userGuid = null; Line 37: Line 38: try { -- To view, visit http://gerrit.ovirt.org/35887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53c721da21cefcf4069d14c7016b6f7d97f9eac9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
