Tomer Saban has posted comments on this change. Change subject: webadmin: Added range values to QoS error message. ......................................................................
Patch Set 4: (2 comments) Fixed on next patch http://gerrit.ovirt.org/#/c/35093/4/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 1145: ACTION_TYPE_FAILED_GEOREP_SESSION_LOCKED=Cannot ${action} ${type}. Another operation is in progress on this geo-replication session. Please try again. Line 1146: Line 1147: ACTION_TYPE_FAILED_TAG_ID_REQUIRED=Cannot ${action} ${type}. Tag ID is required. Line 1148: Line 1149: ACTION_TYPE_FAILED_QOS_CPU_OUT_OF_RANGE_VALUES=Cannot ${action} ${type}. Values are out of range.\n(Legal range is: 1-100). > missing ACTION_TYPE_FAILED_QOS_STORAGE_OUT_OF_RANGE_VALUES Done Line 1150: ACTION_TYPE_FAILED_QOS_STORAGE_POOL_NOT_EXIST=Cannot ${action} ${type}. Invalid data center. Line 1151: ACTION_TYPE_FAILED_QOS_STORAGE_POOL_NOT_CONSISTENT=Cannot ${action} ${type}. Cannot change QoS data center. Line 1152: Line 1153: ACTION_TYPE_FAILED_NETWORK_QOS_MISSING_VALUES=Cannot ${action} ${type}. All three values are needed in order to define QoS on each network directions. http://gerrit.ovirt.org/#/c/35093/4/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 3122: @DefaultStringValue("Cannot ${action} ${type}. The overall committed rate on a single interface must not exceed ${commitmentThreshold}% of the interface's speed, but exceeds this threshold on the following interface(s): ${ACTION_TYPE_FAILED_HOST_NETWORK_QOS_OVERCOMMITMENT_LIST}.") Line 3123: String ACTION_TYPE_FAILED_HOST_NETWORK_QOS_OVERCOMMITMENT(); Line 3124: Line 3125: @DefaultStringValue("Cannot ${action} ${type}. Values are out of range\n(Legal range is: 1-100).") Line 3126: String ACTION_TYPE_FAILED_QOS_CPU_OUT_OF_RANGE_VALUES(); > missing ACTION_TYPE_FAILED_QOS_STORAGE_OUT_OF_RANGE_VALUES? Done Line 3127: Line 3128: @DefaultStringValue("Cannot ${action} ${type}. Invalid data center") Line 3129: String ACTION_TYPE_FAILED_QOS_STORAGE_POOL_NOT_EXIST(); Line 3130: -- To view, visit http://gerrit.ovirt.org/35093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0e1b2ef97624b6b0f3c9c95e7a09e15561a458b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomer Saban <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
