Mike Kolesnik has posted comments on this change.
Change subject: core: STP Allowed Only in VM Network (#839546)
......................................................................
Patch Set 1: (2 inline comments)
Looks good, few minor comments
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
Line 396: NETWORK_INTERFACES_DONT_EXIST,
Line 397: NETWORKS_DONT_EXIST_IN_CLUSTER,
Line 398: NETWORK_BONDS_INVALID_SLAVE_COUNT,
Line 399: NETWORK_CANNOT_DETACH_NETWORK_USED_BY_VMS,
Line 400: NON_VM_NETWORK_CANNOT_BE_STP,
Maybe 'SUPPORT' instead of 'BE'
Line 401: ACTION_TYPE_FAILED_STORAGE_DOMAIN_NOT_IN_STORAGE_POOL,
Line 402: ACTION_TYPE_FAILED_STORAGE_POOL_NOT_EXIST,
Line 403: ACTION_TYPE_FAILED_STORAGE_DOMAIN_NOT_EXIST,
Line 404: ACTION_TYPE_FAILED_STORAGE_CONNECTION,
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
Line 1118: String NETWORK_BONDS_INVALID_SLAVE_COUNT();
Line 1119:
Line 1120: @DefaultStringValue("Cannot ${action} ${type}. The following VMs
are actively using the Logical Network: ${VmNames}. Please stop the VMs and try
again.")
Line 1121: String NETWORK_CANNOT_DETACH_NETWORK_USED_BY_VMS();
Line 1122:
Please remove the trailing whitespace
Line 1123: @DefaultStringValue("Cannot ${action} ${type}. STP can only be
enabled on VM Networks.")
Line 1124: String NON_VM_NETWORK_CANNOT_BE_STP();
Line 1125:
Line 1126: @DefaultStringValue("The currently used VM Snapshot Image cannot
be used in Preview command.")
--
To view, visit http://gerrit.ovirt.org/7305
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5b628aaa62c0113d398781eca97ac5445928624
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
