Martin Peřina has posted comments on this change. Change subject: event map: render optional. ......................................................................
Patch Set 4: Code-Review+1 (1 comment) Small formatting issue, otherwise it's OK http://gerrit.ovirt.org/#/c/31776/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddEventSubscriptionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddEventSubscriptionCommand.java: Line 74: * @return <c>true</c> if [is already subscribed] [the specified Line 75: * subscriptions]; otherwise, <c>false</c>. Line 76: */ Line 77: private static boolean IsAlreadySubscribed(Iterable<event_subscriber> subscriptions, Guid subscriberId, Line 78: String eventName, EventNotificationMethod eventNotificationMethod) { Please revert this formatting Line 79: boolean retval = false; Line 80: for (event_subscriber eventSubscriber : subscriptions) { Line 81: if (subscriberId.equals(eventSubscriber.getsubscriber_id()) Line 82: && StringUtils.equals(eventSubscriber.getevent_up_name(), eventName) -- To view, visit http://gerrit.ovirt.org/31776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93d39249c9b57802948f356b5f0ad470ab7f32b1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Anonymous Coward #1000397 Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
