Michael Pasternak has posted comments on this change.

Change subject: restapi: Create-Disk specify SD by name
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java
Line 49:             if 
(storageDomain.getstorage_name().equals(storageDomainName)) {
Line 50:                 return storageDomain.getId();
Line 51:             }
Line 52:         }
Line 53:         return null;
return notFound() ???
Line 54:     }
Line 55: 
Line 56:     @Override
Line 57:     public Disks list() {


....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java
Line 120:             if 
(storageDomain.getstorage_name().equals(storageDomainName)) {
Line 121:                 return storageDomain.getId();
Line 122:             }
Line 123:         }
Line 124:         return null;
return notFound() ???
Line 125:     }
Line 126: 
Line 127:     @Override
Line 128:     protected VdcActionParametersBase getRemoveParameters(String id) {


--
To view, visit http://gerrit.ovirt.org/7314
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9e994b25bb66098275b7094521e079d94926855
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to