Alon Bar-Lev has posted comments on this change. Change subject: core : Persist engine session on login and delete on logout ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/35361/12/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AbstractGetEntitiesWithPermittedActionParametersQueryTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AbstractGetEntitiesWithPermittedActionParametersQueryTest.java: Line 45: Line 46: EngineSessionDAO engineSessionDAOMock = mock(EngineSessionDAO.class); Line 47: when(engineSessionDAOMock.save(any(EngineSession.class))).thenReturn(RandomUtils.instance().nextLong()); Line 48: when(engineSessionDAOMock.remove(any(Long.class))).thenReturn(1); Line 49: when(engineSessionDAOMock.remove(any(Long.class))).thenReturn(1); > why this line is duplicated ??? Done Line 50: when(dbFacadeMock.getEngineSessionDao()).thenReturn(engineSessionDAOMock); Line 51: Line 52: PermissionDAO permissionsDAOMock = mock(PermissionDAO.class); Line 53: when(permissionsDAOMock.getAllForEntity(any(Guid.class), any(Guid.class), any(Boolean.class))).thenReturn(new ArrayList<Permissions>()); -- To view, visit http://gerrit.ovirt.org/35361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id716d9c6f65898ccd0ffd84d8b05926b78ac9692 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
