Maor Lipchuk has posted comments on this change. Change subject: core: Add alias and description for disk meta data ......................................................................
Patch Set 18: (1 comment) http://gerrit.ovirt.org/#/c/34163/18/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java: Line 184: || validate(diskValidator.isDiskInterfaceSupported(getVm()))) && Line 185: setAndValidateDiskProfiles(); Line 186: } Line 187: Line 188: protected StorageDomainValidator getStorageDomainValidator(DiskImage diskImage) { > I think this is the wrong way to implement all this solution, but just to g Looking at it again, I prefer to leave this that way since the we can only get the Storage from DiskImage. leaving this method with no disk as a parameter will make the method be prone error once it will be called for LUN disk Line 189: if (storageDomainValidator == null) { Line 190: StorageDomain storageDomain = getStorageDomainDAO().getForStoragePool( Line 191: diskImage.getStorageIds().get(0), diskImage.getStoragePoolId()); Line 192: storageDomainValidator = new StorageDomainValidator(storageDomain); -- To view, visit http://gerrit.ovirt.org/34163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2642ae7016579ead699509426e01ac2010bd374 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
