Allon Mureinik has posted comments on this change. Change subject: core: Fix NPE when disk size is not yet set ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/36382/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java: Line 133: } Line 134: Line 135: @JsonIgnore Line 136: public Long getAvailableDiskSizeInBytes() { Line 137: Integer availableSize = getAvailableDiskSize(); > Should probably be a Long No, this is an mistake - disregard Line 138: return availableSize != null ? availableSize * SizeConverter.BYTES_IN_GB : null; Line 139: } Line 140: Line 141: public void setAvailableDiskSize(Integer availableDiskSize) { -- To view, visit http://gerrit.ovirt.org/36382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icca933dcf506ca702161fcfbfe400a7259d20d1a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
