Ayal Baron has posted comments on this change.
Change subject: webadmin: Import VM dialog redesign (#845947)
......................................................................
Patch Set 2: (2 inline comments)
Note that I stopped reviewing at ImportVmModel.java for lack of time. Will try
to go on later.
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java
Line 173: @Override
Line 174: public void OnSuccess(Object model, Object returnValue) {
Line 175: ArrayList<storage_pool> pools =
(ArrayList<storage_pool>) returnValue;
Line 176: storage_pool dataCenter = null;
Line 177: if (pools != null && pools.size() > 0) {
shouldn't this be == 0?
Line 178: dataCenter = pools.get(0);
Line 179: } else {
Line 180: //TODO internal client ERROR
Line 181: }
Line 213: }
Line 214: }
Line 215:
Line 216:
getStorage().setItems(filteredStorageDomain);
Line 217: if (hasQuota) {
why isn't this in a separate method?
Line 218: ArrayList<VdcQueryType>
queryTypeList = new ArrayList<VdcQueryType>();
Line 219:
ArrayList<VdcQueryParametersBase> queryParamsList =
Line 220: new
ArrayList<VdcQueryParametersBase>();
Line 221: for (storage_domains
storage : filteredStorageDomain) {
--
To view, visit http://gerrit.ovirt.org/7313
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b6551b235c66e6a32db0f8842cd8e410d6e0318
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
