Gilad Chaplik has posted comments on this change.
Change subject: core: Fix uninformative quota messages (#838589)
......................................................................
Patch Set 3: (1 inline comment)
This patch missing handling error messages.
we talked about having the log printed out to the user also in the popup... how
can the user, whom doesn't have events view, suppose to know what his quota
status -> this is the main motivation behind it.
you can decide to alter this patch or do in in another.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
Line 319:
log.setFirst(AuditLogType.USER_EXCEEDED_QUOTA_STORAGE_GRACE_LIMIT);
Line 320:
log.setSecond(getLoggableQuotaStorageParams(quota.getQuotaName(),
Line 321: storageUsagePercentage,
Line 322: storageRequestPercentage));
Line 323: if
(QuotaEnforcementTypeEnum.HARD_ENFORCEMENT.equals(quotaEnforcementTypeEnum)) {
this is the most important thing... have the popup error message contain the
log message... both in storage and in cluster
Line 324:
canDoActionMessages.add(VdcBllMessages.ACTION_TYPE_FAILED_QUOTA_STORAGE_LIMIT_EXCEEDED.toString());
Line 325: return false;
Line 326: }
Line 327: }
--
To view, visit http://gerrit.ovirt.org/7220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7c83616b773d7471447944e6dd9adcd49d2d5ac
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
