Maor Lipchuk has posted comments on this change.
Change subject: core: live snapshot failes in case of a deactivated disk
(#845020)
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 166:
TransactionSupport.executeInScope(TransactionScopeOption.Suppress, new
TransactionMethod<Void>() {
Line 167:
Line 168: @Override
Line 169: public Void runInTransaction() {
Line 170: List<Disk> pluggedDisks = new
VmRunHandler().getPluggedDisks(getVm(), DbFacade.getInstance()
Why not using VmRunHandler.getInstance()?
Line 171: .getDiskDao()
Line 172: .getAllForVm(getVm().getId()));
Line 173: runVdsCommand(VDSCommandType.Snapshot,
Line 174: new
SnapshotVDSCommandParameters(getVm().getrun_on_vds().getValue(),
--
To view, visit http://gerrit.ovirt.org/7330
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I27c32525794b4ec3c9d8c78f033a3c9d39da72b9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
