Eldan Shachar has uploaded a new change for review. Change subject: restapi: Editing of template version for stateless VMs and pools ......................................................................
restapi: Editing of template version for stateless VMs and pools This patch will allow a user to change a template version for an existing stateless VM / Pool. The main issues handled are: - VM \ Pool object - added support for changing of the template field. - Frontend - Added support for editing of this field and introduced some limitations to avoid non-supported behaviors. - UpdateVmVersion Command - added support for any template versions. - Pools - Until now pools haven't supported changes affecting the actual VMs and some logic that depended on this assumption needed change. - Running VMs - Changes were required in the next-run logic on multiple locations. Change-Id: I0c3e73962fa26358559cd2aa81da714ce15878e1 Bug-Url: https://bugzilla.redhat.com/1140569 Signed-off-by: Eldan Shachar <[email protected]> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmPoolMapper.java 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/09/36509/1 diff --git a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmPoolMapper.java b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmPoolMapper.java index 0de055a..7734699 100644 --- a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmPoolMapper.java +++ b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmPoolMapper.java @@ -3,6 +3,7 @@ import org.apache.commons.lang.StringUtils; import org.ovirt.engine.api.model.Cluster; import org.ovirt.engine.api.model.Display; +import org.ovirt.engine.api.model.Template; import org.ovirt.engine.api.model.VmPool; import org.ovirt.engine.api.restapi.utils.GuidUtils; import org.ovirt.engine.core.common.businessentities.VM; @@ -45,6 +46,10 @@ if (model.isSetDisplay() && model.getDisplay().isSetProxy()) { entity.setSpiceProxy("".equals(model.getDisplay().getProxy()) ? null : model.getDisplay().getProxy()); } + if (model.isSetTemplate() && + model.getTemplate().isSetId()) { + entity.setVmtGuid(GuidUtils.asGuid(model.getTemplate().getId())); + } return entity; } @@ -84,6 +89,10 @@ display.setProxy(entity.getSpiceProxy()); model.setDisplay(display); } + if (entity.getVmtGuid() != null) { + model.setTemplate(new Template()); + model.getTemplate().setId(entity.getVmtGuid().toString()); + } return model; } -- To view, visit http://gerrit.ovirt.org/36509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0c3e73962fa26358559cd2aa81da714ce15878e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
