Arik Hadas has posted comments on this change. Change subject: core: Adding 3.6 support ......................................................................
Patch Set 1: (6 comments) http://gerrit.ovirt.org/#/c/36518/1/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 89: select fn_db_add_config_value('ClusterEmulatedMachines','rhel6.3.0,pc-1.0','3.1'); Line 90: select fn_db_add_config_value('ClusterEmulatedMachines','rhel6.4.0,pc-1.0','3.2'); Line 91: select fn_db_add_config_value('ClusterEmulatedMachines','rhel6.4.0,pc-1.0,pseries','3.3'); Line 92: select fn_db_add_config_value_for_versions_up_to('ClusterEmulatedMachines','rhel6.5.0,pc-1.0,pseries','3.5'); Line 93: select fn_db_add_config_value('ClusterEmulatedMachines','rhel7.0.0,pc-1.0,pseries','3.6'); looking at getVdsCaps on VDSM running on RHEL 7.0, I see: emulatedMachines = ['pc', 'rhel6.4.0', 'pc-q35-rhel7.0.0', 'q35', 'pc-i440fx-rhel7.0.0', 'rhel6.2.0', 'rhel6.1.0', 'rhel6.5.0', 'rhel6.0.0', 'rhel6.3.0'] so wouldn't it be a problem to use 'rhel7.0.0' ? Line 94: select fn_db_add_config_value('CpuOverCommitDurationMinutes','2','general'); Line 95: --Handling Data directory for ENGINE Line 96: select fn_db_add_config_value('DataDir','/usr/share/engine','general'); Line 97: select fn_db_add_config_value('DBEngine','Postgres','general'); Line 220: -- Mixed domain types in a data center support Line 221: select fn_db_add_config_value_for_versions_up_to('MixedDomainTypesInDataCenter', 'false', '3.3'); Line 222: Line 223: -- default requirement for rng sources (comma-separated string of 'RANDOM' and 'HWRNG') Line 224: select fn_db_add_config_value_for_versions_up_to('ClusterRequiredRngSourcesDefault', '', '3.6'); not sure about this one.. maybe should be RANDOM for 3.6.. Line 225: Line 226: select fn_db_add_config_value_for_versions_up_to('SpiceCopyPasteToggleSupported', 'false', '3.4'); Line 227: -- Graphics Framebuffer Device support Line 228: select fn_db_add_config_value_for_versions_up_to('GraphicsDeviceEnabled','false','3.6'); Line 224: select fn_db_add_config_value_for_versions_up_to('ClusterRequiredRngSourcesDefault', '', '3.6'); Line 225: Line 226: select fn_db_add_config_value_for_versions_up_to('SpiceCopyPasteToggleSupported', 'false', '3.4'); Line 227: -- Graphics Framebuffer Device support Line 228: select fn_db_add_config_value_for_versions_up_to('GraphicsDeviceEnabled','false','3.6'); This should stay 3.5 - feature merged Line 229: Line 230: select fn_db_add_config_value_for_versions_up_to('SpiceFileTransferToggleSupported', 'false', '3.6'); Line 231: select fn_db_add_config_value_for_versions_up_to('StoragePoolMemoryBackend', 'false', '3.4'); Line 232: Line 226: select fn_db_add_config_value_for_versions_up_to('SpiceCopyPasteToggleSupported', 'false', '3.4'); Line 227: -- Graphics Framebuffer Device support Line 228: select fn_db_add_config_value_for_versions_up_to('GraphicsDeviceEnabled','false','3.6'); Line 229: Line 230: select fn_db_add_config_value_for_versions_up_to('SpiceFileTransferToggleSupported', 'false', '3.6'); This should stay 3.5 - feature merged Line 231: select fn_db_add_config_value_for_versions_up_to('StoragePoolMemoryBackend', 'false', '3.4'); Line 232: Line 233: select fn_db_add_config_value_for_versions_up_to('JsonProtocolSupported', 'false', '3.4'); Line 234: select fn_db_add_config_value_for_versions_up_to('VmSlaPolicySupported', 'false', '3.4'); Line 234: select fn_db_add_config_value_for_versions_up_to('VmSlaPolicySupported', 'false', '3.4'); Line 235: Line 236: select fn_db_add_config_value_for_versions_up_to('ReportedDisksLogicalNames', 'false', '3.4'); Line 237: Line 238: select fn_db_add_config_value_for_versions_up_to('AutoConvergenceSupported','false','3.6'); This should stay 3.5 - feature merged Line 239: Line 240: select fn_db_add_config_value_for_versions_up_to('MigrationCompressionSupported','false','3.6'); Line 241: Line 242: -- by default use no proxy Line 236: select fn_db_add_config_value_for_versions_up_to('ReportedDisksLogicalNames', 'false', '3.4'); Line 237: Line 238: select fn_db_add_config_value_for_versions_up_to('AutoConvergenceSupported','false','3.6'); Line 239: Line 240: select fn_db_add_config_value_for_versions_up_to('MigrationCompressionSupported','false','3.6'); This should stay 3.5 - feature merged Line 241: Line 242: -- by default use no proxy Line 243: select fn_db_add_config_value('SpiceProxyDefault','','general'); Line 244: -- To view, visit http://gerrit.ovirt.org/36518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7354f13aabc27f0306afd4f1d2be54f9e71126a1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
