Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Entities for gluster volume snapshot ......................................................................
Patch Set 15: (2 comments) http://gerrit.ovirt.org/#/c/23199/15/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterSnapshotStatus.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterSnapshotStatus.java: Line 1: package org.ovirt.engine.core.common.businessentities.gluster; Line 2: Line 3: public enum GlusterSnapshotStatus { Line 4: ACTIVATED, > Change to STARTED, STOPPED ? I think its done in some following patch. Will order it properly and upload. Line 5: DEACTIVATED, Line 6: UNKNOWN; Line 7: Line 8: public static GlusterSnapshotStatus from(String status) { http://gerrit.ovirt.org/#/c/23199/15/packaging/dbscripts/upgrade/03_06_0660_add_gluster_volume_snapshot_tables.sql File packaging/dbscripts/upgrade/03_06_0660_add_gluster_volume_snapshot_tables.sql: Line 8: status VARCHAR(32), Line 9: _create_date TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT LOCALTIMESTAMP, Line 10: _update_date TIMESTAMP WITH TIME ZONE, Line 11: CONSTRAINT pk_snapshot_id PRIMARY KEY(snapshot_id) Line 12: ) WITH OIDS; > Unique constraint on volume_id and snapshot_name? yes. thats correct. will change it Line 13: Line 14: -- Add gluster_volume_snapshot_config table Line 15: CREATE TABLE gluster_volume_snapshot_config Line 16: ( -- To view, visit http://gerrit.ovirt.org/23199 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idafc74e193fd0d957ee134b53231d99c4ab2e9d8 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Nishanth Thomas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
