Maor Lipchuk has uploaded a new change for review.

Change subject: core: Rephrase bll error message for attaching Storage Domain
......................................................................

core: Rephrase bll error message for attaching Storage Domain

Rephrase message to be more clear.

Change-Id: I1dbb3092fadeec49bd3e38a1487b6a0fd675c967
Bug-Url: https://bugzilla.redhat.com/1176552
Signed-off-by: Maor Lipchuk <[email protected]>
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M 
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M 
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M 
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 7 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/66/36566/1

diff --git 
a/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties 
b/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
index 325a27d..69a91c4 100644
--- 
a/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
+++ 
b/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
@@ -542,8 +542,8 @@
 ERROR_CANNOT_ADD_STORAGE_POOL_WITHOUT_DATA_DOMAIN=Cannot attach Storage 
Domain.\n\
        -Please attach Data Domain to the Data Center first.
 ERROR_CANNOT_ADD_STORAGE_DOMAIN_WITH_ATTACHED_DATA_DOMAIN=Cannot ${action} 
${type}.\n\
- The Storage Domain is already attached to a different Data Center and cannot 
be attcahed to an uninitialized Data Center.\n\
- -Please attach a differenet Data Domain to the Data Center first.
+ The Storage Domain is already attached to a different Data Center and cannot 
be attcahed to a non active Data Center.\n\
+ -Please attach a different Data Domain to the Data Center first or activate 
the Data Center.
 ERROR_CANNOT_REMOVE_POOL_WITH_ACTIVE_DOMAINS=Cannot remove Data Center which 
contains active/locked Storage Domains.\n\
        -Please deactivate all domains and wait for tasks to finish before 
removing the Data Center.
 VDS_GROUP_CANNOT_CHANGE_STORAGE_POOL=Cannot change Data Center association 
when editing a Cluster.
diff --git 
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
 
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
index 6469dac..184d8d1 100644
--- 
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
+++ 
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
@@ -1498,7 +1498,7 @@
     @DefaultStringValue("Cannot attach Storage Domain.\n-Please attach Data 
Domain to the Data Center first.")
     String ERROR_CANNOT_ADD_STORAGE_POOL_WITHOUT_DATA_DOMAIN();
 
-    @DefaultStringValue("Cannot ${action} ${type}.\n The Storage Domain is 
already attached to a different Data Center and cannot be attcahed to an 
uninitialized Data Center.\n -Please attach a differenet Data Domain to the 
Data Center first.")
+    @DefaultStringValue("Cannot ${action} ${type}.\n The Storage Domain is 
already attached to a different Data Center and cannot be attcahed to a non 
active Data Center.\n -Please attach a different Data Domain to the Data Center 
first or activate the Data Center.")
     String ERROR_CANNOT_ADD_STORAGE_DOMAIN_WITH_ATTACHED_DATA_DOMAIN();
 
     @DefaultStringValue("Cannot remove Data Center which contains 
active/locked Storage Domains.\n-Please deactivate all domains and wait for 
tasks to finish before removing the Data Center.")
diff --git 
a/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
 
b/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
index ddb10c7..8c85635 100644
--- 
a/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
+++ 
b/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
@@ -505,8 +505,8 @@
 ERROR_CANNOT_ADD_STORAGE_POOL_WITHOUT_DATA_DOMAIN=Cannot attach Storage 
Domain.\n\
        -Please attach Data Domain to the Data Center first.
 ERROR_CANNOT_ADD_STORAGE_DOMAIN_WITH_ATTACHED_DATA_DOMAIN=Cannot ${action} 
${type}.\n\
- The Storage Domain is already attached to a different Data Center and cannot 
be attcahed to an uninitialized Data Center.\n\
- -Please attach a differenet Data Domain to the Data Center first.
+ The Storage Domain is already attached to a different Data Center and cannot 
be attcahed to a non active Data Center.\n\
+ -Please attach a different Data Domain to the Data Center first or activate 
the Data Center.
 ERROR_CANNOT_REMOVE_POOL_WITH_ACTIVE_DOMAINS=Cannot remove Data Center which 
contains active/locked Storage Domains.\n\
        -Please deactivate all domains and wait for tasks to finish before 
removing the Data Center.
 VDS_GROUP_CANNOT_CHANGE_STORAGE_POOL=Cannot change Data Center association 
when editing a Cluster.
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
 
b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
index e732d0c..84cb1ae 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
+++ 
b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
@@ -546,8 +546,8 @@
 ERROR_CANNOT_ADD_STORAGE_POOL_WITHOUT_DATA_DOMAIN=Cannot attach Storage 
Domain.\n\
        -Please attach Data Domain to the Data Center first.
 ERROR_CANNOT_ADD_STORAGE_DOMAIN_WITH_ATTACHED_DATA_DOMAIN=Cannot ${action} 
${type}.\n\
- The Storage Domain is already attached to a different Data Center and cannot 
be attcahed to an uninitialized Data Center.\n\
- -Please attach a differenet Data Domain to the Data Center first.
+ The Storage Domain is already attached to a different Data Center and cannot 
be attcahed to a non active Data Center.\n\
+ -Please attach a different Data Domain to the Data Center first or activate 
the Data Center.
 ERROR_CANNOT_REMOVE_POOL_WITH_ACTIVE_DOMAINS=Cannot remove Data Center which 
contains active/locked Storage Domains.\n\
        -Please deactivate all domains and wait for tasks to finish before 
removing the Data Center.
 VDS_GROUP_CANNOT_CHANGE_STORAGE_POOL=Cannot change Data Center association 
when editing a Cluster.


-- 
To view, visit http://gerrit.ovirt.org/36566
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1dbb3092fadeec49bd3e38a1487b6a0fd675c967
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to