Juan Hernandez has posted comments on this change.
Change subject: packaging: Clean pgpass file on engine-cleanup
......................................................................
Patch Set 5: (3 inline comments)
....................................................
File packaging/fedora/setup/engine-cleanup.py
Line 180: if not os.path.exists(basedefs.DB_PASS_FILE):
Line 181: logging.debug("The %s file doesn't exist." %
basedefs.DB_PASS_FILE)
Line 182: return
Line 183:
Line 184: if os.path.exists(basedefs.DB_PASS_FILE):
Now you don't need this check :-) .
Line 185: backupFile = "%s.%s" % (basedefs.DB_PASS_FILE,
utils.getCurrentDateTime())
Line 186: logging.debug("Found %s file, backing current to %s" %
(basedefs.DB_PASS_FILE, backupFile))
Line 187: shutil.copyfile(basedefs.DB_PASS_FILE, backupFile)
Line 188:
Line 206: for line in lines:
Line 207: f.write("%s\n" % line)
Line 208:
Line 209: if cleanBackupFile:
Line 210: logging.debug("Removing %s" % backupFile)
Alex suggested using "info" instead of "debug" here.
Line 211: os.remove(backupFile)
Line 212:
Line 213: logging.debug("Cleaning %s completed successfully" %
basedefs.DB_PASS_FILE)
Line 214:
Line 209: if cleanBackupFile:
Line 210: logging.debug("Removing %s" % backupFile)
Line 211: os.remove(backupFile)
Line 212:
Line 213: logging.debug("Cleaning %s completed successfully" %
basedefs.DB_PASS_FILE)
And here.
Line 214:
Line 215:
Line 216: class CA():
Line 217:
--
To view, visit http://gerrit.ovirt.org/7320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I21cbde71bf0a2181f8e0b8ed31205c26d16d2134
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
