Yair Zaslavsky has posted comments on this change. Change subject: core: don't reset custom device props if modified ......................................................................
Patch Set 1: (1 comment) why do you distinguish the case of a major version? What happens if a customer changes a value at 3.5.x, and then upgrades to 3.6? You will lose the customer change? Are we sure this is the correct behavior? From the bug description, it doesnt look like the customer diffrentiates between major and minor builds. http://gerrit.ovirt.org/#/c/36567/1/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 812 Line 813 Line 814 Line 815 Line 816 please remove this comment, or move it to the update section later on. -- To view, visit http://gerrit.ovirt.org/36567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If77c367ec0fea2c9db8475f659b403fee9ded7e4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
