anmolbabu has posted comments on this change.

Change subject: engine : Vds Command for geo-rep session pause
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.ovirt.org/#/c/32666/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java:

Line 1290:     }
Line 1291: 
Line 1292:     @Override
Line 1293:     public StatusOnlyReturnForXmlRpc glusterVolumeGeoRepPause(String 
masterVolumeName, String slaveHost, String slaveVolumeName, boolean force) {
Line 1294:         JsonRpcRequest request = new 
RequestBuilder("GlusterVolume.geoRepPause").withParameter("volumeName", 
masterVolumeName).withParameter("remoteHost", 
slaveHost).withParameter("remoteVolumeName", 
slaveVolumeName).withParameter("force", force).build();
> Format this to be more readable?
Done
Line 1295:         Map<String, Object> response = new FutureMap(this.client, 
request);
Line 1296:         return new StatusOnlyReturnForXmlRpc(response);
Line 1297:     }
Line 1298: 


http://gerrit.ovirt.org/#/c/32666/5/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
File 
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java:

Line 738: 
Line 739:     @DefaultStringValue("Gluster Volume Profile Stop Failed.")
Line 740:     String GlusterVolumeProfileStopFailed();
Line 741: 
Line 742:     @DefaultStringValue("Gluster Volume geo-replication pause failed")
> Message could be "Failed to pause the geo-replication session."
Done
Line 743:     String GlusterVolumeGeoRepPauseFailed();
Line 744: 
Line 745:     String ACTIVATE_NIC_FAILED();
Line 746: 


-- 
To view, visit http://gerrit.ovirt.org/32666
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e34c69b43355b9d8b8305467508047f65aeb05a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to