Alexander Wels has posted comments on this change. Change subject: webadmin: Fix UI plugin REST API HttpSession refresh issue ......................................................................
Patch Set 1: (1 comment) I am trying to decide if I like you passing the OperationManager into the RestApiRefreshManager to register the callback. Or if we should have the OperationManager simply fire an event, and have the RestApiRefreshManager listen to that event. Your option couples the two more than the event option. Let me think about it a little bit. http://gerrit.ovirt.org/#/c/36622/1/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java: Line 23: public static final String HEADER_WWW_AUTHENTICATE = "WWW-Authenticate"; Line 24: public static final String HEADER_PREFER = "Prefer"; Line 25: public static final String HEADER_JSESSIONID_COOKIE = "JSESSIONID"; Line 26: public static final String HEADER_ENGINE_AUTH_TOKEN = "OVIRT-INTERNAL-ENGINE-AUTH-TOKEN"; Line 27: public static final String HEADER_ENGINE_REFRESH = "X-OVIRT-INTERNAL-ENGINE-REFRESH"; None of the other heads are X-something, so I don't think this one should be like that either. Line 28: } Line 29: Line 30: public static final int PREFER_NEW_AUTH = (1<<0); Line 31: public static final int PREFER_PERSISTENCE_AUTH = (1<<1); -- To view, visit http://gerrit.ovirt.org/36622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ffd3198239040f67313238a837af98db16e79ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
