Einav Cohen has posted comments on this change.
Change subject: webadmin,userportal: Frontend improvements
......................................................................
Patch Set 1:
re: section 4 ("<keyPrefix>_<version>_<actualKey>" client storage key format):
- including the "version" part in the key is problematic, as we actually expect
an upgraded oVirt to read the "old" oVirt persisted values (e.g. column widths
in web-admin grids, 'connect automatically' in user-portal login page, etc.).
If we include the version part, and we have e.g. ovirt-3.4 installed with a
bunch of key-values already persisted: once we upgrade to ovirt-3.5, these
values will not be read anymore (therefore, will be practically lost). So I
think that the "version" part should not be included in the key.
- the fact that we are changing the keys will cause an oVirt GUI with this
patch applied to "lose" the client-storage values (that are persisted with the
"old"-format keys). In order to not lose these values, I recommend attempting
to read from the old-format key as a fallback for attempting to read from the
new-format key. writing should be done to the new-format key only; if there is
a smart way of removing the entries with the old-format keys along the way (to
save some client-storage space) - it would be great (nice to have).
--
To view, visit http://gerrit.ovirt.org/36536
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4864b2d4703ee548a570799ed3e87674602f5438
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
