Allon Mureinik has posted comments on this change.
Change subject: core: Add lock to a disk in attach to VM command (#834888)
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
See minor suggestion inline.
Daniel - please review the messages.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
Line 77:
addCanDoActionMessage(VdcBllMessages.ACTION_NOT_SUPPORTED_FOR_CLUSTER_POOL_LEVEL);
Line 78: }
Line 79: if (retValue && !disk.isShareable() && disk.getNumberOfVms() >
0) {
Line 80: retValue = false;
Line 81:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_NOT_SHARABLE_DISK_ALREADY_ATTACHED);
consider adding disk.getVmNames() to the message - may be more user friendly.
Line 82: }
Line 83: if (retValue && isImageDisk &&
getStoragePoolIsoMapDao().get(new StoragePoolIsoMapId(
Line 84: ((DiskImage) disk).getstorage_ids().get(0),
getVm().getstorage_pool_id())) == null) {
Line 85: retValue = false;
--
To view, visit http://gerrit.ovirt.org/7337
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9e47fe370b230b4bd69f108954031cda3bba6a3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
