Alon Bar-Lev has posted comments on this change.

Change subject: webadmin,userportal: Remove general JVM settings from 
gwt-plugin.extraJvmArgs
......................................................................


Patch Set 2:

The -Djava.io.tmpdir -Djava.util.prefs.systemRoot -Djava.util.prefs.userRoot 
should not be removed as these are workaround of gwt plugin bugs that should be 
resolved within the plugin one day.

The jvm options should also remain, as you cannot expect the entire maven to 
have by default the memory requirements of the forked process. You can enable 
override... but by default the maven should take less resources.

-- 
To view, visit http://gerrit.ovirt.org/36739
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaeb92d69f2ba38746559df3e44f34a61fd880908
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Korren <[email protected]>
Gerrit-Reviewer: David Caro <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to