Jakub Niedermertl has posted comments on this change. Change subject: userportal: Templates listing in userportal has multiple columns ......................................................................
Patch Set 1: (5 comments) done http://gerrit.ovirt.org/#/c/36835/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java: Line 97 Line 98 Line 99 Line 100 Line 101 > Are you sure this is not needed? change removed http://gerrit.ovirt.org/#/c/36835/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java: Line 419: Line 420: @Override Line 421: public void setItems(Collection value) { Line 422: genVersionToBaseTemplate(value); Line 423: final List<VmTemplate> sortedValues = sortTemplates(value); > this will affect the sorting also on the webadmin - but on webadmin we supp Done Line 424: super.setItems(sortedValues); Line 425: } Line 426: Line 427: /** http://gerrit.ovirt.org/#/c/36835/1/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedTemplateView.java File frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedTemplateView.java: Line 107: public VmTemplate getValue(VmTemplate template) { Line 108: return template; Line 109: } Line 110: }; Line 111: getTable().addColumn(nameColumn, commonConstants.templateName(), "22em"); //$NON-NLS-1$ done Line 112: Line 113: final TextCellWithTooltip subversionNumberCell = new TextCellWithTooltip(TextCellWithTooltip.UNLIMITED_LENGTH); Line 114: Line 115: final TextColumnWithTooltip<VmTemplate> subversionNumberColumn = new TextColumnWithTooltip<VmTemplate>(subversionNumberCell) { Line 118: public String getValue(VmTemplate template) { Line 119: return "(" + template.getTemplateVersionNumber() + ")"; //$NON-NLS-1$ //$NON-NLS-2$; Line 120: } Line 121: }; Line 122: table.addColumn(subversionNumberColumn, commonConstants.templateVersion(), "9em"); //$NON-NLS-1$ > please use pixels instead of "em" for consistency reasons. Done Line 123: Line 124: final TextCellWithTooltip subversionNameCell = new TextCellWithTooltip(TextCellWithTooltip.UNLIMITED_LENGTH); Line 125: Line 126: final TextColumnWithTooltip subversionNameColumn = new TextColumnWithTooltip<VmTemplate>(subversionNameCell) { Line 131: ? template.getTemplateVersionName() Line 132: : ""; Line 133: } Line 134: }; Line 135: table.addColumn(subversionNameColumn, commonConstants.templateVersionName(), "22em"); //$NON-NLS-1$ > same Done Line 136: Line 137: final TextCellWithTooltip descriptionCell = new TextCellWithTooltip(TextCellWithTooltip.UNLIMITED_LENGTH); Line 138: Line 139: final TextColumnWithTooltip descriptionColumn = new TextColumnWithTooltip<VmTemplate>(descriptionCell) { -- To view, visit http://gerrit.ovirt.org/36835 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72a3a86e20bcbb8e96f75aa3c0609979e7a3aff2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <[email protected]> Gerrit-Reviewer: Jakub Niedermertl <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
