Kanagaraj M has posted comments on this change. Change subject: webadmin : Stop Geo-Rep session ......................................................................
Patch Set 1: (5 comments) http://gerrit.ovirt.org/#/c/35276/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java: Line 152: getNewSessionCommand().setIsAvailable(true); Line 153: getRemoveSessionCommand().setIsAvailable(false); Line 154: getStartSessionCommand().setIsAvailable(false); Line 155: GlusterGeoRepSession selectedSession = (GlusterGeoRepSession) getSelectedItem(); Line 156: getStopSessionCommand().setIsExecutionAllowed(selectedSession != null && selectedSession.getStatus() != GeoRepSessionStatus.NOTSTARTED); what about STOPPED? Line 157: getSessionOptionsCommand().setIsAvailable(false); Line 158: getViewSessionDetailsCommand().setIsAvailable(false); Line 159: } Line 160: Line 205: cModel.setMessage(constants.geoReplicationStopConfirmationTitle()); Line 206: cModel.setForceLabel(constants.geoRepliStringForceStop()); Line 207: cModel.getMasterVolume().setEntity(selectedSession.getMasterVolumeName()); Line 208: cModel.getSlaveVolume().setEntity(selectedSession.getSlaveVolumeName()); Line 209: cModel.getSlaveHost().setEntity(selectedSession.getSlaveHostName()); This should be moved to GlusterVolumeGeoRepActionConfirmationModel Line 210: Line 211: UICommand okCommand = new UICommand("onStopGeoRepSession", this);//$NON-NLS-1$ Line 212: okCommand.setTitle(constants.ok()); Line 213: okCommand.setIsDefault(true); http://gerrit.ovirt.org/#/c/35276/1/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java: Line 290: @DefaultStringValue("Stop Geo Replication") Line 291: String geoReplicationStopConfirmationTitle(); Line 292: Line 293: @DefaultStringValue("Force Stop") Line 294: String geoRepliStringForceStop(); Show help icon explaining the usage of force Line 295: Line 296: @DefaultStringValue("Rebalance Status") Line 297: String volumeRebalanceStatusTitle(); Line 298: http://gerrit.ovirt.org/#/c/35276/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java: Line 153: return new SearchableDetailTabModelProvider<GlusterGeoRepSession, VolumeListModel, VolumeGeoRepListModel>(eventBus, defaultConfirmPopupProvider, VolumeListModel.class, VolumeGeoRepListModel.class) { Line 154: @Override Line 155: public AbstractModelBoundPopupPresenterWidget<? extends Model, ?> getModelPopup(VolumeGeoRepListModel source, UICommand lastExecutedCommand, Model windowModel) { Line 156: if(lastExecutedCommand == getModel().getStopSessionCommand()) { Line 157: return geoRepActionConfirmationPopupProvider.get(); this should go under getConfirmModelPopup Line 158: } else { Line 159: return super.getConfirmModelPopup(source, lastExecutedCommand); Line 160: } Line 161: } http://gerrit.ovirt.org/#/c/35276/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GeoRepActionConfirmPopUpView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GeoRepActionConfirmPopUpView.java: Line 101: }, new Parser<String>() { Line 102: @Override Line 103: public String parse(CharSequence text) throws ParseException { Line 104: return text == null ? constants.notAvailableLabel() : text.toString(); Line 105: } do we need a parser here? Line 106: }); Line 107: } Line 108: Line 109: @Override -- To view, visit http://gerrit.ovirt.org/35276 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If62cce9a18a4e84095b7183f9cbe3b08d0b5e290 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
