Mike Kolesnik has posted comments on this change.
Change subject: core: Change Network Validation (#844396)
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java
Line 81: * @param iface
Line 82: * @param networksByName
Line 83: * @return
Line 84: */
Line 85: public static boolean isValidVmNetwork(VmNetworkInterface iface,
Map<String, Network> networksByName) {
Would you mind adding a few unit tests for this in VmInterfaceManagerTest?
Line 86: String networkName = iface.getNetworkName();
Line 87: return (networksByName.containsKey(networkName) &&
networksByName.get(networkName).isVmNetwork());
Line 88: }
Line 89:
--
To view, visit http://gerrit.ovirt.org/7324
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1081d3c323ac33ee6eb5a3b1aa3a589fe8bc36a6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
