Gilad Chaplik has uploaded a new change for review. Change subject: core: missing cluster policy validation ......................................................................
core: missing cluster policy validation Regression made by recent AddVdsGroupCommand#canDoAction refactoring Change-Id: Ie84058decb0994c1981f77858ff62346884eeeff Signed-off-by: Gilad Chaplik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/91/37191/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java index f977371..87ddd5d 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java @@ -87,6 +87,10 @@ protected boolean canDoAction() { final ClusterValidator validator = new ClusterValidator(getDbFacade(), getVdsGroup()); + if (!validateClusterPolicy()) { + return false; + } + return validate(validator.nameNotUsed()) && validate(validator.cpuTypeSupportsVirtService()) && validate(validator.versionSupported()) -- To view, visit http://gerrit.ovirt.org/37191 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie84058decb0994c1981f77858ff62346884eeeff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
