Alon Bar-Lev has posted comments on this change. Change subject: aaa : Add engine sso ......................................................................
Patch Set 24: (2 comments) http://gerrit.ovirt.org/#/c/36119/24/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/EngineSSOLogoutServlet.java File backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/EngineSSOLogoutServlet.java: Line 23: response.setStatus(HttpURLConnection.HTTP_INTERNAL_ERROR); Line 24: throw new RuntimeException("No application data found in request."); Line 25: } Line 26: if (StringUtils.isEmpty(request.getParameter(SSOUtils.POST_ACTION_URL))) { Line 27: response.setStatus(HttpURLConnection.HTTP_INTERNAL_ERROR); won't it better to set status at catch statement for all exceptions? BTW: isn't this done automatically? Line 28: throw new RuntimeException("No post action url found in request."); Line 29: } Line 30: HttpSession existingSession = request.getSession(false); Line 31: if (existingSession != null) { http://gerrit.ovirt.org/#/c/36119/24/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOUtils.java File backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOUtils.java: Line 62: ObjectMapper mapper = new ObjectMapper().configure(Feature.FAIL_ON_UNKNOWN_PROPERTIES, false) Line 63: .enableDefaultTyping(ObjectMapper.DefaultTyping.OBJECT_AND_NON_CONCRETE); Line 64: mapper.getSerializationConfig().addMixInAnnotations(ExtMap.class, JsonExtMapMixIn.class); Line 65: redirectUrl.append("&opaque="); Line 66: redirectUrl.append(request.getParameter(OPAQUE)); url encode? Line 67: redirectUrl.append("&payload="); Line 68: redirectUrl.append(response.encodeURL(mapper.writeValueAsString(payload))); Line 69: response.sendRedirect(redirectUrl.toString()); Line 70: } catch (SQLException ex) { -- To view, visit http://gerrit.ovirt.org/36119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4894fc12653027271b6abd4dd5313b10593703fa Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
