Juan Hernandez has posted comments on this change. Change subject: core/restapi/webadmin: Support clearing the cluster's emulated machine ......................................................................
Patch Set 2: (1 comment) Ok, understood. http://gerrit.ovirt.org/#/c/37115/2/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterResource.java: Line 105: Line 106: } else { Line 107: throw new WebApplicationException(Response.status(Response.Status.INTERNAL_SERVER_ERROR) Line 108: .entity("Couldn't locate a cluster with the specified id.") Line 109: .build()); If the problem here is that the entity doesn't exist then the resulting HTTP code should be 404, so the status should be NOT_FOUND, not INTERNAL_SERVER_ERROR. There is no need for the error message. If you still want to have an error message then it should be localized, adding a constant to the "Messages" class and the text to the "Messages.properties" file. Line 110: } Line 111: } -- To view, visit http://gerrit.ovirt.org/37115 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e1f70cbbe46fa54edda3f0aa9e56bfd576b8266 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Eldan Shachar <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
