Allon Mureinik has posted comments on this change. Change subject: webadmin : Change message when importing a data domain to an unsupported version ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/37214/1//COMMIT_MSG Commit Message: Line 6: Line 7: webadmin : Change message when importing a data domain to an unsupported version Line 8: Line 9: When importing a data domain to a DC below 3.5 the information message should be changed to : Line 10: "This Data center compatibility version does not support importing a data domain with its entities(VM's and Templates). The imported domain will be imported without them." Please keep the convention of having lines up to 70 chars Line 11: Line 12: Change-Id: I77a292acca38751b078daf61ba5c9ffb7601600a Line 13: Bug-Url: https://bugzilla.redhat.com/1182109 http://gerrit.ovirt.org/#/c/37214/1/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java: Line 227: Line 228: @DefaultStringValue("Data Center is uninitialized, in order to initialize add a data domain") Line 229: String dataCenterUninitializedAlert(); Line 230: Line 231: @DefaultStringValue("This Data Center compatibility version does not support importing a data domain with its entities (VM's and Templates). The imported domain will be imported without them.") Consider "The domain will be imported without them" instead of ""The imported domain will be imported without them". IMHO, it sounds better. Line 232: String dataCenterDoesntSupportImportDataDomainAlert(); Line 233: Line 234: Line 235: @DefaultStringValue("The selected domain already has an ISO domain and an export domains attached") -- To view, visit http://gerrit.ovirt.org/37214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77a292acca38751b078daf61ba5c9ffb7601600a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
