Michael Pasternak has posted comments on this change.
Change subject: restapi: Add 3.1 Features To Capabilities
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 627: <xs:element ref="api" minOccurs="0"/>
Line 628: <xs:element ref="host" minOccurs="0"/>
Line 629: <xs:element ref="url" minOccurs="0"/>
Line 630: <xs:element ref="headers" minOccurs="0"/>
Line 631: </xs:sequence>
white space
Line 632: </xs:extension>
Line 633: </xs:complexContent>
Line 634: </xs:complexType>
Line 635:
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java
Line 78: private void addFeatureRemoveTemplateFromSD(Features features) {
Line 79: Feature feature = new Feature();
Line 80: feature.setName("Remove Template From Specific
Storage-Domain");
Line 81: feature.setDescription("Ability to remove template images from
a specific storage-domain: DELETE
.../api/storagedomains/{storagedomain:id}/templates/{template:id}");
Line 82: features.getFeature().add(feature);
this is not correct, it's about removing template's disk, not the template from
SD,
i.e DELETE /api/templates/xxx/disks/yyy
<action>
<storage_domain id=zzz/>
</action>
Line 83: }
Line 84:
Line 85: private void addFeatureSnapshotsRefactoring(Features features) {
Line 86: Feature feature = new Feature();
Line 105:
Line 106: private void addFeaturePlacementPolicy(Features features) {
Line 107: Feature feature = new Feature();
Line 108: feature.setName("Placement Policy - Ability To Specify Host
By Name");
Line 109: features.getFeature().add(feature);
iirc this is 3.0 feature
Line 110: }
Line 111:
Line 112: private void addFeatureCorrelationId(Features features) {
Line 113: Feature feature = new Feature();
Line 133: private void addFeatureTransparentHugePages(Features features) {
Line 134: Feature feature = new Feature();
Line 135: feature.setName("Transparent-Huge-Pages Memory Policy");
Line 136: feature.setTransparentHugepages(new TransparentHugePages());
Line 137: features.getFeature().add(feature);
this is 3.0 feature
Line 138: }
Line 139:
Line 140: private void addFeatureMaxResults(Features features) {
Line 141: Feature feature = new Feature();
--
To view, visit http://gerrit.ovirt.org/6394
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic20e90027722febc173c833b7c872856e7829147
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
