Oved Ourfali has posted comments on this change. Change subject: core: override SSL protocol to TLSv1 ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/37245/2/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 819: select fn_db_update_config_value('CustomDeviceProperties', '{type=interface;prop={SecurityGroups=^(?:(?:[0-9a-fA-F]{8}-(?:[0-9a-fA-F]{4}-){3}[0-9a-fA-F]{12}, *)*[0-9a-fA-F]{8}-(?:[0-9a-fA-F]{4}-){3}[0-9a-fA-F]{12}|)$}}', '3.5'); Line 820: Line 821: -- Override existing configuration to TLSv1 Line 822: select fn_db_update_config_value('VdsmSSLProtocol','TLSv1','general'); Line 823: select fn_db_update_config_value('ExternalCommunicationProtocol','TLSv1','general'); > shouldn't this be only if previous value is SSLv3? there is another functio it would always be either sslv3 or tlsv1, isn't it? Line 824: Line 825: ------------------------------------------------------------------------------------ Line 826: -- Update only if default not changed section Line 827: ------------------------------------------------------------------------------------ -- To view, visit http://gerrit.ovirt.org/37245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ebf1021231d888451a14201639f623aa1384d82 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
