Moti Asayag has posted comments on this change. Change subject: core: Enable running canDoAction in the same trx with execute ......................................................................
Patch Set 2: (1 comment) please send this patch separated from the other patches, so it can be merge regardless of them (unless it is not a concern for you ATM). Also please see comment inline. http://gerrit.ovirt.org/#/c/37227/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 740: rollbackQuota(); Line 741: } Line 742: Line 743: private boolean isCanDoActionSupportsTransaction() { Line 744: CanDoActionSupportsTransaction annotation = getClass().getAnnotation(CanDoActionSupportsTransaction.class); you've missed Arik's comment from previous patch. Please use Class#isAnnotationPresent instead dup the explicit condition. Line 745: return annotation != null; Line 746: } Line 747: Line 748: private boolean internalCanDoAction() { -- To view, visit http://gerrit.ovirt.org/37227 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41034c27b993ee0cc179f500ed8cf32552f23c81 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
