Doron Fediuck has posted comments on this change.
Change subject: core: Fix handle quota release (#848107)
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Ofri,
OVF is persisting a VM. e need to handle a case where the quota is no longer
relevant. see inline.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
Line 203:
_vm.getStaticData().setis_stateless(Boolean.parseBoolean(node.InnerText));
Line 204: }
Line 205: node = content.SelectSingleNode("quota_id");
Line 206: if (node != null) {
Line 207: _vm.getStaticData().setQuotaId(new Guid(node.InnerText));
Please check the read quota id is relevant.
IE- this may be from old ovf which is no longer has such a quota.
Also, need to handle quota not found...
Line 208: }
Line 209:
Line 210: XmlNodeList list = content.SelectNodes("Section");
Line 211: for (XmlNode section : list) {
--
To view, visit http://gerrit.ovirt.org/7437
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e80028d4c3bf3821a12cbfd164db614a416c464
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
