Arik Hadas has posted comments on this change. Change subject: core : Change AddVmTemplateCommand to not use placeholders mechanism ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/37147/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java: Line 657: } Line 658: } Line 659: Line 660: protected void addVmTemplateImages(Map<Guid, Guid> srcDeviceIdToTargetDeviceIdMapping) { Line 661: Guid vmSnapshotId = Guid.newGuid(); please inline, I see just one usage of this field Line 662: for (DiskImage diskImage : mImages) { Line 663: // The return value of this action is the 'copyImage' task GUID: Line 664: VdcReturnValueBase retValue = Backend.getInstance().runInternalAction( Line 665: VdcActionType.CreateImageTemplate, Line 663: // The return value of this action is the 'copyImage' task GUID: Line 664: VdcReturnValueBase retValue = Backend.getInstance().runInternalAction( Line 665: VdcActionType.CreateImageTemplate, Line 666: buildChildCommandParameters(diskImage, vmSnapshotId), Line 667: cloneContextAndDetachFromParent()); why detaching from parent? Line 668: Line 669: if (!retValue.getSucceeded()) { Line 670: throw new VdcBLLException(retValue.getFault().getError(), retValue.getFault().getMessage()); Line 671: } -- To view, visit http://gerrit.ovirt.org/37147 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07a9dad13443776f88b9bcbdb108eb302d01c555 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
