Roy Golan has posted comments on this change. Change subject: core: missing cluster policy validation ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/37191/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java: Line 97: && validate(validator.glusterServiceSupported()) Line 98: && validate(validator.clusterServiceDefined()) Line 99: && validate(validator.mixedClusterServicesSupported()) Line 100: && validate(validator.attestationServerConfigured()) Line 101: && validate(validator.migrationSupported(getArchitecture())) kudos for the cluster validator ++++ Line 102: && validateClusterPolicy() Line 103: && validate(validator.virtIoRngSupported()); Line 104: } Line 105: -- To view, visit http://gerrit.ovirt.org/37191 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie84058decb0994c1981f77858ff62346884eeeff Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
