Alon Bar-Lev has posted comments on this change. Change subject: packaging: Move defaults out of service script ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) .................................................... File packaging/fedora/engine-service.py Line 309: # Load the configuration and perform checks: Line 310: loadConfig() Line 311: checkIdentity() Line 312: checkInstallation() Line 313: spaces... Line 314: # Get the PID: Line 315: enginePid = loadEnginePid() Line 316: Line 317: # If the PID already exists then we need to check if the -- To view, visit http://gerrit.ovirt.org/7387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I062bb033bf20db9a0d68b8286151345a3653cb03 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
