Roy Golan has posted comments on this change.
Change subject: core: fix adding the right video device type (#849635)
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
Line 166: // if VM does not has CD, add an empty CD
Line 167: if (!shouldHaveCD) {
Line 168: addEmptyCD(dstId);
Line 169: }
Line 170:
because it specifies one thing the block below do which is misleading.
I'll put something more general like:
// specific handling if the destination is a VM
if (isVm) {
// updateBootOrder
...
// create sound card device
...
// create video devices
...
Line 171: if (isVm) {
Line 172: // update devices boot order
Line 173: updateBootOrderInVmDevice(vmBase);
Line 174:
--
To view, visit http://gerrit.ovirt.org/7414
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d28d171b53eb5d44a97f0956384b1012ab5cd1f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
