Juan Hernandez has posted comments on this change.

Change subject: packaging: Generate /etc/httpd/conf.d/ovirt-engine.conf from 
template
......................................................................


Patch Set 4:

A knowledgeable user that changes the AJP port after setup will understand that 
changing this requires changing the web server configuration as well. We can 
add a comment in the /etc/sysconfig/ovirt-engine file to remind this:

  # Note that if you change this port you will also need
  # to change the port in the ProxyPass directive of the
  # /etc/httpd/conf.d/ovirt-engine.conf file.
  ENGINE_AJP_PORT=8009

A less knowledgeable user will not probably change the ports after setup.

I think there is no need to make this more sophisticated.

--
To view, visit http://gerrit.ovirt.org/7398
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8841601e7c56492ef2cc78a78ed1223e97457a2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to