Hello Fred Rolland,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/37445
to review the following change.
Change subject: webadmin: Remove warning on adding Storage Domain
......................................................................
webadmin: Remove warning on adding Storage Domain
Remove warning message about uninitialized Data Center when adding a
storage domain.
Bug-Url: https://bugzilla.redhat.com/1081577
Change-Id: I2649992874687fa2ec85fc262cabfdfb332a142b
Signed-off-by: Fred Rolland <[email protected]>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java
M
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
2 files changed, 4 insertions(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/45/37445/1
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java
index 10c67c1..4d51015 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java
@@ -1,7 +1,5 @@
package org.ovirt.engine.ui.uicommonweb.models.storage;
-import java.util.List;
-
import org.ovirt.engine.core.common.businessentities.StorageDomainType;
import org.ovirt.engine.core.common.businessentities.StoragePool;
import org.ovirt.engine.core.common.businessentities.StoragePoolStatus;
@@ -15,7 +13,8 @@
import org.ovirt.engine.ui.uicommonweb.Linq;
import org.ovirt.engine.ui.uicommonweb.dataprovider.AsyncDataProvider;
import org.ovirt.engine.ui.uicommonweb.models.Model;
-import org.ovirt.engine.ui.uicompat.ConstantsManager;
+
+import java.util.List;
public class NewEditStorageModelBehavior extends StorageModelBehavior
{
@@ -67,14 +66,12 @@
@Override
public boolean shouldShowDataCenterAlert(StoragePool selectedDataCenter) {
- return selectedDataCenter != null
- &&
!getModel().UnassignedDataCenterId.equals(selectedDataCenter.getId())
- && selectedDataCenter.getStatus() ==
StoragePoolStatus.Uninitialized;
+ return false;
}
@Override
public String getDataCenterAlertMessage() {
- return
ConstantsManager.getInstance().getConstants().dataCenterUninitializedAlert();
+ return "";
}
@Override
diff --git
a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
index 36e786a..6330a22 100644
---
a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
+++
b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
@@ -225,9 +225,6 @@
@DefaultStringValue("Storage")
String storageTitle();
- @DefaultStringValue("Data Center is uninitialized, in order to initialize
add a data domain")
- String dataCenterUninitializedAlert();
-
@DefaultStringValue("The selected Data Center compatibility version does
not support importing a data domain with its entities (VM's and Templates). The
domain will be imported without them.")
String dataCenterDoesntSupportImportDataDomainAlert();
--
To view, visit http://gerrit.ovirt.org/37445
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2649992874687fa2ec85fc262cabfdfb332a142b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <[email protected]>
Gerrit-Reviewer: Fred Rolland <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
