Moti Asayag has posted comments on this change. Change subject: core: removed constructor from VmInterfacemanager ......................................................................
Patch Set 3: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/36573/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java: Line 37: import org.slf4j.LoggerFactory; Line 38: Line 39: /** Line 40: * Helper class to use for adding/removing {@link VmNic}s. Line 41: */ A recommendation: it seems it can be annotated with @singleton and be injected whenever is required. Line 42: public class VmInterfaceManager { Line 43: Line 44: private Logger log = LoggerFactory.getLogger(getClass()); Line 45: -- To view, visit http://gerrit.ovirt.org/36573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65aaf5e2c189d2e43e1102b10f621ede0a628aa3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
