Ori Liel has uploaded a new change for review. Change subject: restapi: 500 instead of 404 for api/events/search ......................................................................
restapi: 500 instead of 404 for api/events/search Change-Id: Icf2a7f2abcc3ddae675c6ec2f677380ed25ac121 Signed-off-by: Ori Liel <[email protected]> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendEventsResource.java 1 file changed, 9 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/88/7488/1 diff --git a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendEventsResource.java b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendEventsResource.java index c84fb3e..133abde 100644 --- a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendEventsResource.java +++ b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendEventsResource.java @@ -42,12 +42,16 @@ } public Event lookupEvent(String id) { - Long longId = Long.valueOf(id); - for (AuditLog auditLog : getBackendCollection()) { - if (auditLog.getaudit_log_id() == longId) - return addLinks(map(auditLog)); + try { + Long longId = Long.valueOf(id); + for (AuditLog auditLog : getBackendCollection()) { + if (auditLog.getaudit_log_id() == longId) + return addLinks(map(auditLog)); + } + return notFound(); + } catch (NumberFormatException e) { + return notFound(); } - return notFound(); } @Override -- To view, visit http://gerrit.ovirt.org/7488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icf2a7f2abcc3ddae675c6ec2f677380ed25ac121 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
