mooli tayer has posted comments on this change. Change subject: userportal,webadmin: permission dialog layout ......................................................................
Patch Set 2: Verified+1 (2 comments) verified see: https://bugzilla.redhat.com/show_bug.cgi?id=1121065#c16 http://gerrit.ovirt.org/#/c/37524/2//COMMIT_MSG Commit Message: Line 11: not change the layout if they are too big. Line 12: - Modified the layout of the dialog to be bootstrap grid based Line 13: instead of the manual pixel layout it was before. Line 14: Line 15: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1121065 reoreder? it seems to be important to someone somewhere for some reason. Line 16: Line 17: Change-Id: I3b9a694c6aa4bd18256ae1175440d9b9eeca55a1 http://gerrit.ovirt.org/#/c/37524/2/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.ui.xml File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.ui.xml: Line 9: } Line 10: Line 11: .label { Line 12: font-size: 13px; Line 13: padding: 0 0px; > this might have some bad effects on every other widget? checked a bunch of dialogs, they look good #networks-virtual_machines looks a bit odd, not sure if related. Line 14: font-family: Arial, sans-serif; Line 15: line-height: 16px; Line 16: } Line 17: -- To view, visit http://gerrit.ovirt.org/37524 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b9a694c6aa4bd18256ae1175440d9b9eeca55a1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
