Yair Zaslavsky has posted comments on this change.
Change subject: engine: Added new column 'ssh_key_fingerprint' in the
vds_static table
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
Line 128: private boolean autoRecoverable = true;
Line 129:
Line 130: @Size(max = BusinessEntitiesDefinitions.SSH_KEY_FINGERPRINT_SIZE)
Line 131: @Column(name = "ssh_key_fingerprint")
Line 132: private String ssh_key_fingerprint;
please use java contention here.
Yes, I know we have issues with previous fields (due to historical reason).
Should be sshKeyFingerPrint (I'll settle for sshKeyFingerprint as well).
This will effect the rest of the code (getters, setters, mapper at DAO, and so
on...)
Line 133:
Line 134: public boolean isAutoRecoverable() {
Line 135: return autoRecoverable;
Line 136: }
--
To view, visit http://gerrit.ovirt.org/7171
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7abe03b62dc15bb135fa02e0a43b763abd8872af
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
