David Caro has posted comments on this change. Change subject: Add CentOS 7 build ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/37564/1/centos-7/Makefile File centos-7/Makefile: Line 35: rpm -ql livecd-tools > /dev/null 2>&1 || \ Line 36: yum install -y \ Line 37: http://people.centos.org/arrfab/CentOS7/LiveMedia/RPMS/livecd-tools-20.1-2.el7.x86_64.rpm \ Line 38: http://people.centos.org/arrfab/CentOS7/LiveMedia/RPMS/python-imgcreate-20.1-2.el7.x86_64.rpm \ Line 39: http://people.centos.org/arrfab/CentOS7/LiveMedia/RPMS/hfsplus-tools-540.1.linux3-4.el7.x86_64.rpm This is very ugly (for the ci automation). We should make sure one of: * We run this inside mock * We don't run this section Line 40: Line 41: Line 42: .SUFFIXES: Line 43: .SUFFIXES: .in http://gerrit.ovirt.org/#/c/37564/1/centos-7/kickstart/ovirt-live-ovirt-custom.ks.in File centos-7/kickstart/ovirt-live-ovirt-custom.ks.in: Line 95: %post Line 96: Line 97: #enabling iptables Line 98: systemctl enable iptables.service Line 99: systemctl start iptables.service We don't support yet firewalld? Line 100: Line 101: mkdir -p /home/liveuser/oVirtLiveFiles Line 102: cp -r /root/oVirtLiveFiles /home/liveuser Line 103: echo '10.0.0.1 livecd.localdomain localdomain' >> /etc/hosts -- To view, visit http://gerrit.ovirt.org/37564 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a2d90850cf7e4e00511fb506ebce49d5f61564b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
