Roy Golan has posted comments on this change. Change subject: pythonlib: allow java home bypass ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37590/1/packaging/bin/java-home File packaging/bin/java-home: Line 30: # If system environment contains Line 31: # our specific java look only this one Line 32: # Line 33: if [ -n "${OVIRT_ENGINE_JAVA_HOME}" ]; then Line 34: if [ -n "${OVIRT_ENGINE_JAVA_HOME_FORCE}" ] || validjre "${OVIRT_ENGINE_JAVA_HOME}"; then > it is validating a different variable. correct Sandro thanks Line 35: echo "${OVIRT_ENGINE_JAVA_HOME}" Line 36: exit 0 Line 37: else Line 38: exit 1 -- To view, visit http://gerrit.ovirt.org/37590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f6c59fea689cff7ad4e8d33dad14e398a649ea6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
