Moti Asayag has posted comments on this change. Change subject: restapi: Calculate singulars correctly ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37517/1/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlBuilder.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlBuilder.java: Line 595: O would you prefer extracting the patterns into a separate class/enum, so this method wouldn't have to be modified in the future when new cases are added to it ? i thought about something like: enum PluralToSingular { IES_SUFFIX("ies", "y"), S_SUFFIX("s", ""), ... ERRATA_SUFFIX("errata", "erratum"); } Another case which isn't covered here and probably doesn't exist currently in the code is suffix "es", i.e. boxes --> box. Not sure if required. -- To view, visit http://gerrit.ovirt.org/37517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbd00642de18637e2620433395b3065a062a4ee9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
