Lior Vernia has posted comments on this change. Change subject: core: Add total RX/TX bytes to NetworkStatistics ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/36467/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkStatistics.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkStatistics.java: Line 140: this.receivedBytesOffset = receivedBytesOffset; Line 141: } Line 142: Line 143: /** Line 144: * Hets the value by which total RX statistics should be offset (due to counter reset). > s/Hets/Gets or Returns Done Line 145: * Line 146: * @return the RX byte offset. Line 147: */ Line 148: public Long getReceivedBytesOffset() { Line 151: Line 152: /** Line 153: * Sets the value by which total TX statistics should be offset (due to counter reset). Line 154: * Line 155: * @param receivedBytesOffset > transmitBytesOffset Done Line 156: * the TX byte offset. Line 157: */ Line 158: public void setTransmittedBytesOffset(Long transmittedBytesOffset) { Line 159: this.transmittedBytesOffset = transmittedBytesOffset; Line 154: * Line 155: * @param receivedBytesOffset Line 156: * the TX byte offset. Line 157: */ Line 158: public void setTransmittedBytesOffset(Long transmittedBytesOffset) { > Please place the method after getTransmittedBytes(..) You sure? The convention in this file seems to be setter before getter. Line 159: this.transmittedBytesOffset = transmittedBytesOffset; Line 160: } Line 161: Line 162: /** -- To view, visit http://gerrit.ovirt.org/36467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1178faca34203b01b6fc120bf7f65ba1caf500a8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
